[PATCH] D146033: [AArch64][TTI] Cost model FADD/FSUB/FNEG

[David Spickett via Phabricator via llvm-commits]

DavidSpickett added a comment.

FYI I got some warnings from this new code, using clang 14.0.5:

  /home/david.spickett/llvm-project/llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:2421:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
    case ISD::FMUL:
    ^
  /home/david.spickett/llvm-project/llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:2421:3: note: insert 'LLVM_FALLTHROUGH;' to silence this warning
    case ISD::FMUL:
    ^
    LLVM_FALLTHROUGH;
  /home/david.spickett/llvm-project/llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:2421:3: note: insert 'break;' to avoid fall-through
    case ISD::FMUL:
    ^
    break;

Though the existing code directly above also doesn't annotate it either, so if you feel like fixing it in another patch maybe do that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146033/new/

https://reviews.llvm.org/D146033