[PATCH] D146438: [RISCV][MC] Refine MCInstrAnalysis based on registers used

Job Noorman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 11 01:08:02 PDT 2023


jobnoorman added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVMCTargetDesc.cpp:196
+    case RISCV::JALR:
+      return Inst.getOperand(0).getReg() == RISCV::X0;
+    }
----------------
craig.topper wrote:
> Does this need to check `!maybeReturnAddress` so that isBranch doesn't return true for the same case as isReturn?
It does! Will add in next update.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146438/new/

https://reviews.llvm.org/D146438



More information about the llvm-commits mailing list