[PATCH] D147763: [ARM] Align code to 4-byte boundary after .arm directive

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

Tests updates look OK to me.

A couple of comments overall.

- While I personally prefer the proposed behaviour as I don't think anyone other than CPU and toolchain validation tests should want to write an unaligned instruction; this is a difference in behaviour with GNU assembler. Can we add to the Arm section of the LLVM release notes to the next release? Could also be worth a binutils bug to see if we can get GNU to follow.
- If `.arm` is going to be aligning to a 4-byte boundary then .thumb should be aligning to a 2-byte boundary. It doesn't look like it is at the moment. While less likely to be a problem in practice I think it is important that it gets done so that the behaviour of the directives is consistent. Could be done in a follow up patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147763/new/

https://reviews.llvm.org/D147763