[PATCH] D147994: Handle null dereference

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/WinEHPrepare.cpp:254
       auto *Call = dyn_cast<CallBase>(TI);
+      assert(Call);
       const Function *Fn = Call->getCalledFunction();
----------------
skan wrote:
> https://llvm.org/docs/CodingStandards.html#assert-liberally
> 
>  put some kind of error message in the assertion statement,
Use cast instead of dyn_cast. cast has an internal assert


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147994/new/

https://reviews.llvm.org/D147994