[PATCH] D145761: [MTE] [llvm-readobj] Add globals section parsing to --memtag

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

No more comments from me, as aside from one minor suggestion in the test.

It probably needs a review from someone familiar with the memtag encoding though, as I'm not.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/AArch64/memtag.test:334
+# BAD-STREAM1: warning: {{.*}} error decoding distance uleb, 3 byte(s) into
+# BAD-STREAM1: SHT_AARCH64_MEMTAG_GLOBALS_DYNAMIC
+
----------------
I don't think we have the same line length expectations in lit tests, so I personally wouldn't split the messages across multiple checks like this, due to the fact they have a slight difference in behaviour. However, I don't have a strong opinion on it, so if you prefer it this way, that's fine. I would make it a CHECK-SAME directive though (and if you do that, I'd add some spaces before "warning" to make the second CHECK's contents line up with the first one i.e.

```
# BAD-STREAM1:      warning: ...
# BAD-STREAM1-SAME: SHT_...
```

Same comment applies below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145761/new/

https://reviews.llvm.org/D145761