[PATCH] D147975: [StackProtector] don't check stack protector before calling nounwind functions

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm accepted this revision.
xiangzhangllvm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/StackProtector.cpp:490
+          // __cxa_throw).
+          if (CB->doesNotReturn() && !CB->doesNotThrow()) {
+            CheckLoc = CB;
----------------
I +1 for this constraints to reduce code size.
For C level except (setjmp longjmp) they mainly set/read register status from function parameter not stack. So low risk.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147975/new/

https://reviews.llvm.org/D147975