[PATCH] D140975: Support critical edge splitting for jump tables

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 10 16:25:03 PDT 2023


efriedma added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:1063
+    MachineJumpTableInfo *MJTI = MF->getJumpTableInfo();
+    MJTI->ReplaceMBBInJumpTable(JTI, Succ, NMBB);
+  }
----------------
Have we proven at this point that this jump is the only use of the jump table in question?  With optimizations like tail duplication, you could have multiple basic blocks referencing the same table.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140975/new/

https://reviews.llvm.org/D140975



More information about the llvm-commits mailing list