[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

[Paul Kirth via Phabricator via llvm-commits]

paulkirth added inline comments.


================
Comment at: clang/lib/Driver/SanitizerArgs.cpp:573
+                                 Kinds & SanitizerKind::ShadowCallStack)
+          << "-msmall-data-limit=0";
+    }
----------------
jrtc27 wrote:
> jrtc27 wrote:
> > paulkirth wrote:
> > > jrtc27 wrote:
> > > > Why is this an error? It may be a misguided thing to enable but it is 100% supported to combine this. All the limit does is put things in .sdata, but they can still be addressed just fine.
> > > My understanding is that (whether they should or not) linkers are using the presence of the `.sdata` section to enable gp relaxation. 
> > That is not true
> Putting variables in .sdata merely makes it more likely that the linker will be able to relax accesses to them to use GP. Variables outside .sdata still can and will be relaxed if within range of whatever gets picked for `__global_pointer$`.
Yes, I seem to have had been under the wrong impression. I've dropped everything regarding `-msmall-data-limit`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146463/new/

https://reviews.llvm.org/D146463