[PATCH] D147849: [Android] Use ELF TLS for Android API level 29+

Mon Apr 10 15:48:40 PDT 2023

rprichard added a comment.

In D147849#4256641 <https://reviews.llvm.org/D147849#4256641>, @enh wrote:

> In D147849#4256504 <https://reviews.llvm.org/D147849#4256504>, @rprichard wrote:
>
>> One issue I noticed earlier was that the compiler flag (`-f[no-]emulated-tls`) doesn't work with LTO:
>>
>> - The flag is ignored when the compiler is only outputting LLVM IR, and
>> - The flag is also ignored at link-time when the IR is converted to emutls-or-efltls machine code.
>>
>> This link-time LTO setting can be changed using `-Wl,-plugin-opt,-emulated-tls={0,1}`.
>
> does https://reviews.llvm.org/D147834 fix this?

Thanks, I hadn't seen that before. Yes, that should make `-f[no-]emulated-tls` work with LTO.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147849/new/

https://reviews.llvm.org/D147849