[PATCH] D145884: test-release.sh: build projects and runtimes lists with semicolons

Dimitry Andric via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 10 15:10:57 PDT 2023


dim added a comment.

In D145884#4256208 <https://reviews.llvm.org/D145884#4256208>, @amyk wrote:

> I think this makes sense, as I can even see on the Phase 3 of building LLVM, the following message during configuration:
>
>   -- Could NOT find ZLIB (missing: ZLIB_LIBRARY) (found version "1.2.11")
>
> Whereas I get a message for Phase 3 saying that the ZLIB library was found (prior to building with this patched version of `test-release.sh`).

Interesting, it will depend on which mechanism is used to find zlib. I am unsure if the standard CMake functionality is used for this, or a hand-written llvm-specific thing. I will see if I can dig a bit into this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145884/new/

https://reviews.llvm.org/D145884



More information about the llvm-commits mailing list