[PATCH] D147649: [Reland][ADT][ConcurrentHashTable] adapt ConcurrentHashTable and its users to LLVM_ENABLE_THREADS=0 mode.

Mon Apr 10 14:10:04 PDT 2023

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

It's a bit unfortunate that we have to sprinkle `LLVM_ENABLE_THREADS` throughout the code, but not enough that I think it's worth doing anything fancy like subclassing (I think it would just make things worse). LGTM.

================
Comment at: llvm/include/llvm/DWARFLinkerParallel/StringPool.h:25

-class PerThreadStringAllocator
-    : public AllocatorBase<PerThreadStringAllocator> {
+class SimpleStringAllocator : public AllocatorBase<SimpleStringAllocator> {
 public:
----------------
Why not just `StringAllocator`. Do we expect to have a more "complex" allocator down the line?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147649/new/

https://reviews.llvm.org/D147649