[PATCH] D147947: [AArch64][GISel] Add FP16 fcmp lowering

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp:459
+            return Ty.isVector() && Ty.getElementType() == s16 &&
+                   !ST.hasFullFP16();
+          },
----------------
I think you can use the existing `HasFP16` variable here.

(There's also a `MinFPScalar` variable which is `s16` when there's full FP16 support, and `s32` otherwise, but I'm not sure if that fits into the logic here at all?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147947/new/

https://reviews.llvm.org/D147947