[PATCH] D147937: fix: Link `atomic` into LLVMOrcJIT on platforms without hardware support for atomics

[Owen Shepherd via Phabricator via llvm-commits]

414owen created this revision.
Herald added a subscriber: hiraditya.
Herald added a project: All.
414owen updated this revision to Diff 512136.
414owen added a comment.
414owen retitled this revision from "fix: Link atomic in ORC on platforms that need it" to "fix: Link `atomic` into LLVMOrcJIT on platforms without hardware support for atomics".
414owen edited the summary of this revision.
Herald added a subscriber: kristof.beyls.
414owen added a reviewer: lhames.
414owen published this revision for review.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Added better git commit description


When linking LLVMOrcJit on ARMv6, I get an error about a missing reference to `__atomic_fetch_add_8`.

This seems to be because on platforms without hardware support, we need to link in `atomic`.

The full error is below:

  [ 66%] Linking CXX shared library ../../libLLVMOrcJIT.so
  /usr/bin/ld: CMakeFiles/LLVMOrcJIT.dir/ObjectLinkingLayer.cpp.o: in function `llvm::orc::ObjectLinkingLayer::add(llvm::IntrusiveRefCntPtr<llvm::orc::ResourceTracker>, std::unique_ptr<llvm::jitlink::LinkGraph, std::default_delete<llvm::jitlink::LinkGraph> >)':
  ObjectLinkingLayer.cpp:(.text._ZN4llvm3orc18ObjectLinkingLayer3addENS_18IntrusiveRefCntPtrINS0_15ResourceTrackerEEESt10unique_ptrINS_7jitlink9LinkGraphESt14default_deleteIS7_EE+0x3e0): undefined reference to `__atomic_fetch_add_8'
  collect2: error: ld returned 1 exit status
  gmake[2]: *** [lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/build.make:659: lib/libLLVMOrcJIT.so.14] Error 1
  gmake[1]: *** [CMakeFiles/Makefile2:13868: lib/ExecutionEngine/Orc/CMakeFiles/LLVMOrcJIT.dir/all] Error 2
  gmake: *** [Makefile:171: all] Error 2


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D147937

Files:
  llvm/lib/ExecutionEngine/Orc/CMakeLists.txt


Index: llvm/lib/ExecutionEngine/Orc/CMakeLists.txt
===================================================================
--- llvm/lib/ExecutionEngine/Orc/CMakeLists.txt
+++ llvm/lib/ExecutionEngine/Orc/CMakeLists.txt
@@ -1,3 +1,7 @@
+if (NOT HAVE_CXX_ATOMICS64_WITHOUT_LIB)
+  set (atomic_lib atomic)
+endif()
+
 if( CMAKE_HOST_UNIX AND HAVE_LIBRT )
   set(rt_lib rt)
 endif()
@@ -53,6 +57,7 @@
   LINK_LIBS
   ${LLVM_PTHREAD_LIB}
   ${rt_lib}
+  ${atomic_lib}
 
   LINK_COMPONENTS
   Core


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147937.512136.patch
Type: text/x-patch
Size: 488 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230410/7514daad/attachment.bin>