[PATCH] D147921: [X86][AMX] Add check for potentially dereferencing null return value

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 10 02:08:09 PDT 2023


xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:491
   if (IsPHI) {
-    Value *PhiOp = dyn_cast<PHINode>(V)->getIncomingValue(0);
+    Value *PhiOp = cast<PHINode>(V)->getIncomingValue(0);
     II = cast<IntrinsicInst>(PhiOp);
----------------
Make sense for type check, but any bug meet by previous code?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147921/new/

https://reviews.llvm.org/D147921



More information about the llvm-commits mailing list