[PATCH] D146349: [InstCombine] Make `FoldOpIntoSelect` handle non-constants and use condition to deduce constants.
Noah Goldstein via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 9 17:17:21 PDT 2023
goldstein.w.n added a comment.
In D146349#4208910 <https://reviews.llvm.org/D146349#4208910>, @nikic wrote:
> Can you please rebase over https://github.com/llvm/llvm-project/commit/d0de2c51c9a9fc0fedb97ee98f61ce08cb34972b? I hope that will clarify what the actual change here is, because making foldOperationIntoSelectOperand() fallible doesn't make a whole lot of sense.
Done and agreed. Updated version only uses the information from the condition
to improve the constant folding.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146349/new/
https://reviews.llvm.org/D146349
More information about the llvm-commits
mailing list