[PATCH] D147504: [WebAssembly] `AsmTypeCheck` support to br instr

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmTypeCheck.cpp:448-449
                                                        " missing .tagtype");
-    // catch instruction pushes values whose types are specified in the tag's
-    // "params" part
+    // if nest structure is good, last BrStack is operand stack in try instr;
+    Stack = BrStack.back().getEnterStack();
+    // catch instruction pushes values whose types are specified in the
----------------
I don't think we should restore try's `EnterStack` here? In a `catch` body, the only input params are the caught values, not the `try`'s input types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147504/new/

https://reviews.llvm.org/D147504