[PATCH] D147852: [WebAssembly] Handle block-like structures consistently in type checker
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 9 03:23:17 PDT 2023
aheejin added inline comments.
================
Comment at: llvm/test/MC/WebAssembly/type-checker-errors.s:277
else
# FIXME: Should complain about insufficient values on the stack.
end_if
----------------
This (and another FIXME `end_if_type_mismatch_2`) is not done even with this patch due to another bug, which I'm planning to fix in another CL.
I renamed these to tests to `else_***` to `end_if_***` so that `else_***` means checking types when we encounter `else`, and `end_if_***` means checking types when we encounter `end_if`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147852/new/
https://reviews.llvm.org/D147852
More information about the llvm-commits
mailing list