[PATCH] D147783: [VPlan] Add stride->constant VPlan mapping at construction.

[Peixin Qiao via Phabricator via llvm-commits]

peixin added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8914
+    else
+      Plan->addVPValue(Stride, new VPValue(CI));
+  }
----------------
Ayal wrote:
> nit: can alternatively do
> 
> ```
>   Plan->getOrAddVPValue(Stride);
>   assert(Plan->getVPValue(Stride)->getLiveInIRValue() == CI &&
>          "Adding different constants for the same stride!");
> ```
> ?
I am thinking if it is really needed? The symblic strides are stored in one ValueToValueMap. It seems to be impossible to may different constants for the same stride.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147783/new/

https://reviews.llvm.org/D147783