[PATCH] D147777: [Assignment Tracking] Fix fragments for assignments to variables smaller than the alloca

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

> What would be the implications of a store that partially overlaps an AT tracked variable -- as a result of this patch, we would lose some of that information (to avoid a crash)?

Yeah that's right.

> It feels like an extremely unlikely edge case, so doesn't worry me too much, but is the ultimate fix to truncate the assignment here, or just not produce that kind of debug-info in the first place? And if the latter, should we assert for that, or just conclude "SROA really hates what you're doing in this situation".

I think truncating would make sense too - I've added a note in the comments but I think you're right that the situation should be extremely rare.

Thanks for the review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147777/new/

https://reviews.llvm.org/D147777