[PATCH] D147862: [compiler-rt] [test] Generalize the triple regex for windows XFAILs

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 8 13:17:18 PDT 2023


mstorsjo created this revision.
mstorsjo added reviewers: phosek, alvinhochun, vitalybuka, omjavaid.
Herald added subscribers: Enna1, dberris.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a project: Sanitizers.
Herald added a subscriber: Sanitizers.

Don't hardcode the vendor field in the triples to "pc"; for mingw
environments it's often "<arch>-w64-windows-gnu".


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D147862

Files:
  compiler-rt/test/builtins/Unit/divmodti4_test.c
  compiler-rt/test/builtins/Unit/fixunstfdi_test.c
  compiler-rt/test/builtins/Unit/multc3_test.c


Index: compiler-rt/test/builtins/Unit/multc3_test.c
===================================================================
--- compiler-rt/test/builtins/Unit/multc3_test.c
+++ compiler-rt/test/builtins/Unit/multc3_test.c
@@ -1,4 +1,4 @@
-// XFAIL: target=aarch64-pc-windows-{{.*}}
+// XFAIL: target=aarch64-{{.*}}-windows-{{.*}}
 // RUN: %clang_builtins %s %librt -o %t && %run %t
 // REQUIRES: librt_has_multc3
 
Index: compiler-rt/test/builtins/Unit/fixunstfdi_test.c
===================================================================
--- compiler-rt/test/builtins/Unit/fixunstfdi_test.c
+++ compiler-rt/test/builtins/Unit/fixunstfdi_test.c
@@ -1,4 +1,4 @@
-// XFAIL: target=aarch64-pc-windows-{{.*}}
+// XFAIL: target=aarch64-{{.*}}-windows-{{.*}}
 // RUN: %clang_builtins %s %librt -o %t && %run %t
 // REQUIRES: librt_has_fixunstfdi
 
Index: compiler-rt/test/builtins/Unit/divmodti4_test.c
===================================================================
--- compiler-rt/test/builtins/Unit/divmodti4_test.c
+++ compiler-rt/test/builtins/Unit/divmodti4_test.c
@@ -1,4 +1,4 @@
-// XFAIL: target=aarch64-pc-windows-{{.*}}
+// XFAIL: target=aarch64-{{.*}}-windows-{{.*}}
 // RUN: %clang_builtins %s %librt -o %t && %run %t
 // REQUIRES: librt_has_divmodti4
 // REQUIRES: int128


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147862.511927.patch
Type: text/x-patch
Size: 1280 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230408/ac936f70/attachment.bin>


More information about the llvm-commits mailing list