[PATCH] D147858: [libunwind] [test] Mark the signal_frame test as unsupported on Windows

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 8 13:05:41 PDT 2023


mstorsjo created this revision.
mstorsjo added reviewers: alvinhochun, cdavis5x, phosek.
Herald added subscribers: pengfei, kristof.beyls.
Herald added projects: libunwind, All.
Herald added a reviewer: libunwind.
mstorsjo requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Mark it as unsupported on x86_64, arm and aarch64. On i686, DWARF
is used as the default unwinding format, and there, the CFI
directives are supported.

I'm not sure if it's worth to keep the complex regex to allow the
test to be run on i686 - we could also just mark it unsupported on
all windows variants.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D147858

Files:
  libunwind/test/signal_frame.pass.cpp


Index: libunwind/test/signal_frame.pass.cpp
===================================================================
--- libunwind/test/signal_frame.pass.cpp
+++ libunwind/test/signal_frame.pass.cpp
@@ -21,6 +21,10 @@
 // are necessary to run this test.
 // UNSUPPORTED: target=powerpc{{(64)?}}-ibm-aix
 
+// Windows doesn't generally use CFI directives. However, i686
+// mingw targets do use DWARF (where CFI directives are supported).
+// UNSUPPORTED: target={{x86_64|arm.*|aarch64}}-{{.*}}-windows-{{.*}}
+
 #undef NDEBUG
 #include <assert.h>
 #include <stdlib.h>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147858.511923.patch
Type: text/x-patch
Size: 563 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230408/c59ffffb/attachment.bin>


More information about the llvm-commits mailing list