[PATCH] D139907: [FuzzMutate] RandomIRBuilder has more source and sink type now.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 8 05:04:12 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/FuzzMutate/RandomIRBuilder.cpp:268
+    return !Callee->hasParamAttribute(OperandNo, Attribute::ImmArg) ||
+           isa<Constant>(Replacement);
+  }
----------------
Allowing replacement of immarg with any Constant is too broad, it only allows ConstantInt. Additionally, replacing the value may be a bit risky. Might as well just skip all immarg arguments


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139907/new/

https://reviews.llvm.org/D139907



More information about the llvm-commits mailing list