[PATCH] D146914: Migrate `IIT_Info` into `Intrinsics.td`

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/utils/TableGen/IntrinsicEmitter.cpp:193
+    auto Number = Rec->getValueAsInt("Number");
+    assert(0 <= Number && Number < 256 && "IIT_Info.Number should be uint8_t");
+    assert(RecsByNumber[Number].empty() && "Duplicate IIT_Info.Number");
----------------
arsenm wrote:
> assert(isUInt<8>(Number))
This isn't done? isUInt<8> would be clearer (or at least swap the compare to be Number >= 0)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146914/new/

https://reviews.llvm.org/D146914