[PATCH] D147547: [AMDGPU] Add buffer intrinsics that take resources as pointers

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1072-1073
+  AMDGPURsrcIntrinsic<0>;
+def int_amdgcn_raw_buffer_ptr_load_format : AMDGPURawBufferPtrLoad<llvm_anyfloat_ty>;
+def int_amdgcn_raw_buffer_ptr_load : AMDGPURawBufferPtrLoad;
+
----------------
I'd lean towards swapping the naming around, so that you would have "int_amdgcn_raw_ptr_buffer_load". That way the ISA opcode name part remains unbroken 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147547/new/

https://reviews.llvm.org/D147547