[PATCH] D147709: Rename llvm/utils/TableGen/X86ManualFoldTables.def to .inc

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

GMNGeoffrey added a comment.

Since Bazel is not a generally-supported build system, we shouldn't be making changes to the source solely for the benefit of the Bazel build system. I do find it a bit weird that LLVM uses the ".def" extension for these files, given that it's the extension for MSVC module definition files <https://learn.microsoft.com/en-us/cpp/build/reference/module-definition-dot-def-files?view=msvc-170>, but the usage appears to be widespread <https://github.com/search?q=repo%3Allvm%2Fllvm-project%20path%3A.def&type=code> in the project, so I don't think it makes sense to just change this one file unless there's something that distinguishes it from the others outside of how Bazel feels about it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147709/new/

https://reviews.llvm.org/D147709