[PATCH] D147728: [X86] Add inst fixup for `unpckpd` -> `unpckqdq`.

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n marked an inline comment as done.
goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Target/X86/X86FixupInstTuning.cpp:157-158
 
   // `vunpcklpd/vmovlhps r, r` -> `vshufps r, r, 0x44`
   // `vunpckhpd/vmovlhps r, r` -> `vshufps r, r, 0xee`
   // `vunpcklpd r, r, k` -> `vshufpd r, r, 0x00`
----------------
pengfei wrote:
> Update the comments here.
Likewise for the `unpckps` changes.


================
Comment at: llvm/lib/Target/X86/X86FixupInstTuning.cpp:250-257
   case X86::MOVLHPSrr:
   case X86::UNPCKLPDrr:
-    return ProcessUNPCKLPDrr(X86::SHUFPSrri);
+    return ProcessUNPCKLPDrr(X86::PUNPCKLQDQrr, X86::SHUFPSrri);
   case X86::VMOVLHPSrr:
   case X86::VUNPCKLPDrr:
-    return ProcessUNPCKLPDrr(X86::VSHUFPSrri);
+    return ProcessUNPCKLPDrr(X86::VPUNPCKLQDQrr, X86::VSHUFPSrri);
   case X86::VUNPCKLPDYrr:
----------------
pengfei wrote:
> Change `PS` to `PD`.
Also added tests for this case in D147726


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147728/new/

https://reviews.llvm.org/D147728