[PATCH] D147597: [InstCombine] Fold icmp(bin(X, Y) | LHS, RHS) --> icmp(bin(X, Y)) iff LHS > RHS s>= 0

[Jun Zhang via Phabricator via llvm-commits]

junaire added a comment.

Hi @goldstein.w.n, please discard all my previous comments (sorry Phab doesn't allow me to delete inline comments :(

So I agree with you with `m_BinOp` is unnecessary and the transform is correct. Please take a look at https://alive2.llvm.org/ce/z/97gSUu
In fact, I guess we can add more generalized patterns based on the relation between LHS and RHS?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147597/new/

https://reviews.llvm.org/D147597