[PATCH] D147584: [lld] Support separate minimized bitcode file path in --thinlto-prefix-replace

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Apologies, I'm on an intense trip and will have little time studying patches before April 12...



================
Comment at: lld/ELF/Config.h:180
   std::pair<llvm::StringRef, llvm::StringRef> thinLTOObjectSuffixReplace;
   llvm::StringRef thinLTOPrefixReplaceOld;
   llvm::StringRef thinLTOPrefixReplaceNew;
----------------
tejohnson wrote:
> Similar name changes here and in other Config.h to what I suggested above.
> 
> @MaskRay, would it be good to add comments about what these variables are, as is done in the COFF config file? I notice that there are no comments on any of the variables, but I think it might be helpful for these in particular.
Yes, having a comment will be useful.


================
Comment at: lld/test/COFF/thinlto-minimized-bitcode-prefix-replace.ll:4
+;; prefix of minimized bitcode files
+; RUN: rm -rf %t && mkdir %t &&  mkdir %t/minimized && mkdir %t/full && mkdir %t/indexing
+
----------------
`... && mkdir -p %t/minimized %t/full %t/indexing`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147584/new/

https://reviews.llvm.org/D147584