[PATCH] D147683: AMDGPU: mark SET_INACTIVE_* as convergent operation

Ruiling, Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 6 20:46:15 PDT 2023


ruiling added a comment.

In D147683#4250292 <https://reviews.llvm.org/D147683#4250292>, @arsenm wrote:

> Does tablegen not infer convergent instructions from the source pattern? I assume not (but I always found this to be a dubious feature)

I am not familiar with that part. Maybe we still prefer the convergent property being explicitly managed. But I think it might be helpful to at least generate warning if the pattern selection drops convergent property.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147683/new/

https://reviews.llvm.org/D147683



More information about the llvm-commits mailing list