[PATCH] D134490: [NFC] check for UnreachableInst first as it is cheaper compared to getTerminatingDeoptimizeCall

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya marked an inline comment as done.
hiraditya added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/BasicBlockUtils.cpp:504
          VisitedBlocks.insert(BB).second) {
-    if (BB->getTerminatingDeoptimizeCall() ||
-        isa<UnreachableInst>(BB->getTerminator()))
+    if (isa<UnreachableInst>(BB->getTerminator() ||
+        BB->getTerminatingDeoptimizeCall()))
----------------
Peter wrote:
> Are we `bitwise or` two pointers of different type or is the parentheses wrong?
fixed. thanks for pointing it out.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134490/new/

https://reviews.llvm.org/D134490