[PATCH] D147694: [FunctionAttrs] Fix nounwind inference for landingpads

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 6 11:44:30 PDT 2023


nikic added a comment.

In D147694#4249509 <https://reviews.llvm.org/D147694#4249509>, @efriedma wrote:

> Doesn't that have the same problem as the issue you're trying to fix?  Specifically, if there's a catchswitch pointing to a cleanuppad that ends in "unreachable", mayThrow() returns false for both the catchswitch and the cleanuppad.

Yeah, you're right. In that case the catchswich is not "unwind to caller" so it won't be considered mayThrow() and we do need separate handling for the cleanuppad.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147694/new/

https://reviews.llvm.org/D147694



More information about the llvm-commits mailing list