[PATCH] D147608: [RISCV] Lower scalar_to_vector

[Luke Lau via Phabricator via llvm-commits]

luke added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:4116
+    if (Scalar.getValueType().isInteger())
+      Scalar = DAG.getZExtOrTrunc(Scalar, DL, Subtarget.getXLenVT());
+    SDValue V = DAG.getNode(RISCVISD::VMV_S_X_VL, DL, ContainerVT,
----------------
craig.topper wrote:
> Why wouldn't the scalar already be XLenVT?
Whoops you're right, can't remember why I added this. Maybe it was when I was trying to get it working with `i1`s? Removed anyway


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147608/new/

https://reviews.llvm.org/D147608