[PATCH] D142796: Flang semantic check support for tile and unroll OpenMP Directive.

[Abid via Phabricator via llvm-commits]

abidmalikwaterloo marked an inline comment as done.
abidmalikwaterloo added inline comments.


================
Comment at: flang/lib/Semantics/check-omp-structure.h:63-71
+static OmpDirectiveSet taskloopSet{Directive::OMPD_taskloop,
+    Directive::OMPD_taskloop_simd, Directive::OMPD_tile,
+    Directive::OMPD_unroll};
 static OmpDirectiveSet targetSet{Directive::OMPD_target,
     Directive::OMPD_target_parallel, Directive::OMPD_target_parallel_do,
     Directive::OMPD_target_parallel_do_simd, Directive::OMPD_target_simd,
     Directive::OMPD_target_teams, Directive::OMPD_target_teams_distribute,
----------------
kiranchandramohan wrote:
> Are these changes required?
My understanding is that the tile/unroll constructs can be called from the most loop-related directives. That's why I make both of them part of the set.


================
Comment at: flang/lib/Semantics/check-omp-structure.h:72
+    OMPD_unroll};
+static OmpDirectiveSet tileSet{Directive::OMPD_tile};
 static OmpDirectiveSet simdSet{Directive::OMPD_distribute_parallel_do_simd,
----------------
kiranchandramohan wrote:
> Why is this change required?
Again,  my understanding is there will set of constructs that will be called from the tileset.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142796/new/

https://reviews.llvm.org/D142796