[PATCH] D147716: [FastISel] Correctly report prototype on miss
Alexis Engelke via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 6 08:34:37 PDT 2023
aengelke created this revision.
aengelke added reviewers: ab, craig.topper, efriedma.
Herald added a subscriber: hiraditya.
Herald added a project: All.
aengelke requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
The type of a function is nowadays just an opaque pointer, which is not
helpful when analyzing FastISel misses. Instead print the actual
function type of the function.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D147716
Files:
llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
Index: llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
===================================================================
--- llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
+++ llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
@@ -1449,7 +1449,7 @@
Fn.getSubprogram(),
&Fn.getEntryBlock());
R << "FastISel didn't lower all arguments: "
- << ore::NV("Prototype", Fn.getType());
+ << ore::NV("Prototype", Fn.getFunctionType());
reportFastISelFailure(*MF, *ORE, R, EnableFastISelAbort > 1);
// Use SelectionDAG argument lowering
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147716.511428.patch
Type: text/x-patch
Size: 640 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230406/9dc823d9/attachment.bin>
More information about the llvm-commits
mailing list