[PATCH] D147709: Rename llvm/utils/TableGen/X86ManualFoldTables.def to .inc

[NAKAMURA Takumi via Phabricator via llvm-commits]

chapuni created this revision.
Herald added a project: All.
chapuni requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Unfortunately, Bazel doesn't accept `.def` as header fragments in `cc_binary`.
(Corresponding to CMake's `add_executable`)
In addition, `.def` is sometimes used to Win32's module definitions.

Could you avoid using `.def` here?

Note, Bazel's `cc_library` may accept header files with any suffix.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D147709

Files:
  llvm/utils/TableGen/X86FoldTablesEmitter.cpp
  llvm/utils/TableGen/X86ManualFoldTables.def
  llvm/utils/TableGen/X86ManualFoldTables.inc
  utils/bazel/llvm-project-overlay/llvm/BUILD.bazel


Index: utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
===================================================================
--- utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
+++ utils/bazel/llvm-project-overlay/llvm/BUILD.bazel
@@ -597,11 +597,6 @@
     ],
 )
 
-cc_library(
-    name = "llvm-tblgen-headers",
-    textual_hdrs = glob(["utils/TableGen/*.def"]),
-)
-
 cc_binary(
     name = "llvm-tblgen",
     srcs = glob([
@@ -621,7 +616,6 @@
         ":Support",
         ":TableGen",
         ":config",
-        ":llvm-tblgen-headers",
     ],
 )
 
Index: llvm/utils/TableGen/X86ManualFoldTables.inc
===================================================================
--- llvm/utils/TableGen/X86ManualFoldTables.inc
+++ llvm/utils/TableGen/X86ManualFoldTables.inc
@@ -1,4 +1,4 @@
-//===- X86ManualFoldTables.def ----------------------------*- C++ -*-==//
+//===- X86ManualFoldTables.inc -----------------------------------*- C++ -*-==//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
Index: llvm/utils/TableGen/X86FoldTablesEmitter.cpp
===================================================================
--- llvm/utils/TableGen/X86FoldTablesEmitter.cpp
+++ llvm/utils/TableGen/X86FoldTablesEmitter.cpp
@@ -42,12 +42,12 @@
 
 const ManualMapEntry ManualMapSet[] = {
 #define ENTRY(REG, MEM, FLAGS) {#REG, #MEM, FLAGS},
-#include "X86ManualFoldTables.def"
+#include "X86ManualFoldTables.inc"
 };
 
 const std::set<StringRef> NoFoldSet= {
 #define NOFOLD(INSN) #INSN,
-#include "X86ManualFoldTables.def"
+#include "X86ManualFoldTables.inc"
 };
 
 static bool isExplicitAlign(const CodeGenInstruction *Inst) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147709.511403.patch
Type: text/x-patch
Size: 1717 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230406/a0c07ea5/attachment.bin>