[PATCH] D147700: [llvm-exegesis] Allow setting dump file name

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: llvm/tools/llvm-exegesis/lib/BenchmarkRunner.h:67-68
   Expected<Benchmark> runConfiguration(RunnableConfiguration &&RC,
-                                                  bool DumpObjectToDisk) const;
+                                       bool DumpObjectToDisk,
+                                       StringRef DumpFileName) const;
 
----------------
Given that `DumpFileName` only makes sense if `DumpObjectToDisk`, use a single `optional<StringRef>` parameter ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147700/new/

https://reviews.llvm.org/D147700