[PATCH] D147699: [llvm-exegesis][AArch64] Add return statement at the end of the snippet correctly

[Pavel Kosov via Phabricator via llvm-commits]

kpdev42 created this revision.
kpdev42 added reviewers: tstellar, courbet, lebedev.ri.
kpdev42 added a project: LLVM.
Herald added subscribers: StephenFan, mstojanovic, kristof.beyls.
Herald added a project: All.
kpdev42 requested review of this revision.

Currently llvm-exegesis fails to do this which causes every snippet to crash


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D147699

Files:
  llvm/test/tools/llvm-exegesis/AArch64/add-return.s
  llvm/tools/llvm-exegesis/lib/Assembler.cpp


Index: llvm/tools/llvm-exegesis/lib/Assembler.cpp
===================================================================
--- llvm/tools/llvm-exegesis/lib/Assembler.cpp
+++ llvm/tools/llvm-exegesis/lib/Assembler.cpp
@@ -132,8 +132,8 @@
 
     FunctionLoweringInfo FuncInfo;
     FuncInfo.CanLowerReturn = true;
-    MF.getSubtarget().getCallLowering()->lowerReturn(MIB, nullptr, {},
-                                                     FuncInfo);
+    MF.getSubtarget().getCallLowering()->lowerReturn(MIB, nullptr, {}, FuncInfo,
+                                                     0);
   }
 }
 
Index: llvm/test/tools/llvm-exegesis/AArch64/add-return.s
===================================================================
--- /dev/null
+++ llvm/test/tools/llvm-exegesis/AArch64/add-return.s
@@ -0,0 +1,5 @@
+# RUN: llvm-exegesis --opcode-name=ADDv16i8 --mcpu=cortex-a78 --mtriple=aarch64-linux-gnu \
+# RUN:               --mode=latency --benchmark-phase=assemble-measured-code 2>&1 | FileCheck %s
+
+# Check that we add ret (bx lr) instr to snippet
+# CHECK: assembled_snippet: {{.*}}C0035FD6


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147699.511365.patch
Type: text/x-patch
Size: 1092 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230406/75219800/attachment.bin>