[PATCH] D147647: [compiler-rt] [test] [builtins] Pass the right parameters for linking with -nodefaultlibs on mingw targets

[Alvin Wong via Phabricator via llvm-commits]

alvinhochun added inline comments.


================
Comment at: compiler-rt/test/builtins/Unit/lit.cfg.py:51
+    # Don't pass dosish path separator to msys bash.exe.
+    base_lib = base_lib.replace('\\', '/')
+  config.substitutions.append( ("%librt ", base_lib + ' -lmingw32 -lmoldname -lmingwex -lmsvcrt -ladvapi32 -lshell32 -luser32 -lkernel32 ') )
----------------
Just wondering is this really needed? I had assumed that the lit test runner handles passing paths with backslashes just fine. Though I guess there is no harm in replacing them with forward slashes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147647/new/

https://reviews.llvm.org/D147647