[PATCH] D145301: Add more efficient vector bitcast for AArch64

Lawrence Benson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 6 02:28:01 PDT 2023


lawben updated this revision to Diff 511335.
lawben added a comment.

Addressed some review comments.

Main changes:

- Removed the truncate store code. I'll add this in a follow-up patch.
- Defensively added a `AND 1` check if we dont have a `SETCC` chain for correct truncation.

The failing tests from before are solved for now. Most were related to truncating stores, which is not part of this patch anymore.
The dag-combine-setcc tests were adapted in a recent patch <https://reviews.llvm.org/D146518>, so they no longer apply.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145301/new/

https://reviews.llvm.org/D145301

Files:
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/test/CodeGen/AArch64/vec-combine-compare-to-bitmask.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D145301.511335.patch
Type: text/x-patch
Size: 16510 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230406/d4c3add6/attachment.bin>


More information about the llvm-commits mailing list