[PATCH] D147058: [SimpleLoopUnswitch] Fix SCEV invalidation issue

Thu Apr 6 00:58:43 PDT 2023

bjope added a comment.

In D147058#4247648 <https://reviews.llvm.org/D147058#4247648>, @fhahn wrote:

> LGTM, thanks! It would be nice to have a test for the switch case as well, but it’s fine to avoid the crash preemptively

Thanks.
Unfortunately I do not have a test case for the switch case. Maybe we could trigger it by some more fuzzy testing with random input directed at this pass (knowing that there also has to be some pass before it that has computed scev for the outer loops, so maybe using a passes string similar to the lit test I added here), if we really want to hunt down such a test case. Right here and now I do prefer to avoid the crash preemptively, so I've landed this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147058/new/

https://reviews.llvm.org/D147058