[PATCH] D147450: [GuardWidening] Re-factor freezeAndPush

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 5 23:42:03 PDT 2023


mkazantsev accepted this revision.
mkazantsev added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Transforms/Scalar/GuardWidening.cpp:610
+    Value *Def = U.get();
+    if (!(isa<Constant>(Def) || isa<GlobalValue>(Def)))
+      return false;
----------------
`if (!isa<Constant> && !isa<GlobalValue>)`? Easier to understand (maybe it's just me :) )


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147450/new/

https://reviews.llvm.org/D147450



More information about the llvm-commits mailing list