[PATCH] D147662: [LoopPredication] Fix where we generate widened condition. PR61963

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 5 20:57:47 PDT 2023


mkazantsev added a comment.

I generally agree with the change in code, but can we shrink the test? I'm pretty sure most of things here are not really required.



================
Comment at: llvm/test/Transforms/LoopPredication/pr61963.ll:11
+; CHECK-NEXT: %widenable_cond11 = call i1 @llvm.experimental.widenable.condition
+define i32 @foo(ptr addrspace(3) %arg) !prof !0 {
+bb:
----------------
Is it possible to reduce the test via bugpoint? Just assert whenever you move non-loop-invariant into loop in this transform and let it do the job.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147662/new/

https://reviews.llvm.org/D147662



More information about the llvm-commits mailing list