[PATCH] D147270: [DebugInfo] Support more than 2 operands in DWARF operations

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 5 13:56:46 PDT 2023


scott.linder added a comment.

In D147270#4241303 <https://reviews.llvm.org/D147270#4241303>, @dblaikie wrote:

> Got any measurements of memory usage? (seems like this'd increase memory usage? Maybe try a self-host release build (optimizations causing more interesting locations and so more location operations) & see how peak memory usage in various compilation changes?)

I will run the tests you suggest and report back; I didn't initially because there are already 3-operand operations, and hence for completeness we will have to change at some point. The only remaining question in my mind is the approach to support it: either statically sized and compile-time evaluated (i.e. `DWARFExpression::Operation`) or dynamically sized (i.e. `LVOperation`). I will try to measure which approach better balances LLVM compile time, artifact size, compile time, etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147270/new/

https://reviews.llvm.org/D147270



More information about the llvm-commits mailing list