[PATCH] D147269: [DebugInfo] printCompactDWARFExpr: don't assert on stack size

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 5 13:53:15 PDT 2023


scott.linder added a comment.

In D147269#4241315 <https://reviews.llvm.org/D147269#4241315>, @dblaikie wrote:

> Not the best error handling (like might be better returning Error from this function?) but probably OK.

I agree, but to avoid shaving too many yaks I adopted the existing mechanism for error handling in the function, which is to write an error message to `OS` and return `false`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147269/new/

https://reviews.llvm.org/D147269



More information about the llvm-commits mailing list