[PATCH] D147583: Fix bazel overlay after "[mlir] Introduce IRDL dialect"

Geoffrey Martin-Noble via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 5 13:42:05 PDT 2023


GMNGeoffrey added a comment.

In D147583#4244871 <https://reviews.llvm.org/D147583#4244871>, @dblaikie wrote:

> Sounds good, thanks.
>
> (you don't actually need to send these sort ofthings for presubmit review - you can use phab in draft mode (arc --draft, ifyou're using arc, I think) to get the presubmit checks run without sending for review, then submit directly - if the blaze build's already broken anyway, there's little haram in committing something to it that has some chance of fixing the issue... )

David would you mind adding this to the README <https://github.com/llvm/llvm-project/tree/main/utils/bazel>. I didn't know about draft mode and while I think we've discussed "no need to send trivial build fixes for review" in various places it doesn't appear to be documented


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147583/new/

https://reviews.llvm.org/D147583



More information about the llvm-commits mailing list