[PATCH] D147645: [InstCombine] Sink bin op into select if first or second value is simplified to constant

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added a comment.

In D147645#4246621 <https://reviews.llvm.org/D147645#4246621>, @nikic wrote:

> Can you please regenerate checks for these files and rebase? There are lots of spurious naming diffs that make it hard to see what actually changed.

Yes sure



================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:924
       return NewSel;
+    if (I.getOpcode() == BinaryOperator::Xor) return nullptr;
+    if (!True && isa_and_nonnull<Constant>(False))
----------------
Somehow getting infinite loops here is Xor is allowed. GDB points to foldSelectOfBools..




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147645/new/

https://reviews.llvm.org/D147645