[PATCH] D147456: [AutoFDO] Stale profile matching(part 1)

Wed Apr 5 12:08:18 PDT 2023

davidxl added a comment.

In D147456#4246695 <https://reviews.llvm.org/D147456#4246695>, @hoy wrote:

> In D147456#4246648 <https://reviews.llvm.org/D147456#4246648>, @davidxl wrote:
>
>> 
>
>
>
>> By the way, another way is to offline remapping --- basically 'correcting' the stale profile by mapping the old locations to the new locations and produce a refreshed profile.  This is what we plan to do internally.
>
> This sounds interesting. By offline do you mean the profile generation time? Wondering how to get the new locations without building the new binary.

Right -- the source revision information is available for any target in the build environment.

================
Comment at: llvm/lib/Transforms/IPO/SampleProfile.cpp:451
+  // of current build is matched to the location in the profile.
+  StringMap<LocToLocMap> FuncToMatchingsMap;

----------------
wenlei wrote:
> hoy wrote:
> > Where is this DS populated? Is it in a separate patch?
> same question. I saw it being populated in the 2nd patch, but the split between the two patches is a bit weird if its population is left out. not a big deal though as long as the entire stack works..
It is better make that part available to review at the same time for better context.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147456/new/

https://reviews.llvm.org/D147456