[PATCH] D147267: [NFC][DebugInfo] Make Descriptions constexpr

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 5 11:06:25 PDT 2023


scott.linder added a comment.

In D147267#4241300 <https://reviews.llvm.org/D147267#4241300>, @dblaikie wrote:

> Sure - though could you check if there's any revision history that explains the comment further/motivates why this would be valuable? (I have some apprehension about making extra things constexpr as it can increase compile time excessively (forcing the frontend to check for evaluation - when the backend can more cheaply optimize it away later anyway))

Sure, I did just blindly assume the TODO had merit. Is there a structured way you tend to evaluate these on a case-by-case basis? Should I compare instructions retired while compiling LLVM+Clang and while using the resulting LLVM+Clang to inspect DebugInfo with and without the change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147267/new/

https://reviews.llvm.org/D147267



More information about the llvm-commits mailing list