[PATCH] D147078: [LICM][BPF] Disable hoistMinMax() optimization for BPF target

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 5 09:58:46 PDT 2023


xbolva00 added a comment.

>> Undoing it in the backend is fragile.

Can you explain it why? or in CodegenPrepare? Why is it fragile?

As a bonus you will handle situation when there is  < min(...) directly in your code.

Backends must follow some rules given by the design of LLVM, LLVM should not be full of ugly hacks to make backends happy, and currently we saw no proofs that undo transform is not possible to do it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147078/new/

https://reviews.llvm.org/D147078



More information about the llvm-commits mailing list