[PATCH] D99169: [DebugInfo] Replace debug uses in replaceUsesOutsideBlock

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D99169#4246075 <https://reviews.llvm.org/D99169#4246075>, @Orlando wrote:

> In D99169#4246001 <https://reviews.llvm.org/D99169#4246001>, @nikic wrote:
>
>> Please either convert the llvm/test/DebugInfo/Generic/instcombine-replaced-select-with-operand.ll test to use opaque pointers, or delete it if it's not relevant anymore (the thing it currently tests is based on pointer bitcasts).
>
> Done in 1a0653a80dee2b0db5fb44f50777153fb7690a4f <https://reviews.llvm.org/rG1a0653a80dee2b0db5fb44f50777153fb7690a4f>. I just replaced the typed pointers with opaque pointers because that still stimulates the code-path we want to test here (I checked the test still fails when the code change is reverted). If that's weird or not in keeping, the next option is to regenerate  from the source, and if that doesn't work then I think dropping the test wouldn't be the end of the world given we have unittest coverage of the underlying functionality.

Thanks! I was mainly uncertain because the bitcast will now just get optimized away and not folded into the select or similar. But if this still covers the relevant codepath, that's great.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99169/new/

https://reviews.llvm.org/D99169